[Merged by Bors] - Add bors to CI #1684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also simplified some names
Test262 conformance changes:
|
Codecov Report
@@ Coverage Diff @@
## main #1684 +/- ##
=======================================
Coverage ? 44.40%
=======================================
Files ? 203
Lines ? 20270
Branches ? 0
=======================================
Hits ? 9000
Misses ? 11270
Partials ? 0 Continue to review full report at Codecov.
|
raskad
approved these changes
Oct 23, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Oct 23, 2021
This Pull Request updates some of our CI config and adds config for bors. It changes the following: - remove `cargo check` from CI (`cargo test` should be enough) - change back to `cargo tarpaulin` on Linux to get coverage information - simplify some of the CI steps' names - add workflow for bors ##### Working with bors It's setup so that we need 2 approvals before we can merge like we discussed in Discord. After the second approval we can write a comment with `bors r+` so that the merge is tested. bors will only run if `test`, `rustfmt`, `clippy`, `examples` and `doc` are all running error free in the PR's branch. It will then run them again in a `staging` branch that is the equivalent of merging the PR on `main`. Another option we can consider is `up_to_date_approvals`, so that new commits make previous approvals not count. The bors reference can be found here: https://bors.tech/documentation/
|
Pull request successfully merged into main. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates some of our CI config and adds config for bors.
It changes the following:
cargo checkfrom CI (cargo testshould be enough)cargo tarpaulinon Linux to get coverage informationWorking with bors
It's setup so that we need 2 approvals before we can merge like we discussed in Discord.
After the second approval we can write a comment with
bors r+so that the merge is tested.bors will only run if
test,rustfmt,clippy,examplesanddocare all running error free in the PR's branch. It will then run them again in astagingbranch that is the equivalent of merging the PR onmain.Another option we can consider is
up_to_date_approvals, so that new commits make previous approvals not count.The bors reference can be found here: https://bors.tech/documentation/