Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parseInt, parseFloat missing #447

Closed
tomasol opened this issue Jun 2, 2020 · 3 comments · Fixed by #459
Closed

parseInt, parseFloat missing #447

tomasol opened this issue Jun 2, 2020 · 3 comments · Fixed by #459
Assignees
@Lan2u
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Milestone
v0.9.0

Comments

@tomasol
Copy link

tomasol commented Jun 2, 2020

I don't see a list of unsupported language features, so I'm adding this. Functions parseInt, parseFloat are not defined.

To Reproduce
Start CLI, enter

parseInt(10)

Expected behavior
10 should be returned. Actual result: undefined.
Build environment (please complete the following information):

  • boa version: master (87aea64)
  • OS: Ubuntu
  • Version: 20.04
  • Target triple: x86_64-unknown-linux-gnu
  • Rustc version: 1.43.1 (8d69840ab 2020-05-04)
@tomasol tomasol added the bug Something isn't working label Jun 2, 2020
@Razican Razican added enhancement New feature or request and removed bug Something isn't working labels Jun 2, 2020
@Razican
Copy link
Member

Razican commented Jun 2, 2020

Yep, as you say, we still don't have a list of missing feature. We are working on this by implementing test262 harness (#12).

In this case, these functions are not implemented AFAIK.

@Lan2u
Copy link

Lan2u commented Jun 3, 2020

I can try and implement this

@HalidOdat
Copy link
Member

Sure! go for it :)

@HalidOdat HalidOdat added the builtins PRs and Issues related to builtins/intrinsics label Jun 3, 2020
@Lan2u Lan2u mentioned this issue Jun 6, 2020
Merged
@Razican Razican added this to the v0.9.0 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lan2u Lan2u

Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

parseInt, parseFloat implementation
4 participants
@tomasol @Razican @HalidOdat @Lan2u