Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Symbol() as a field's value #405

Closed
n14little opened this issue May 18, 2020 · 1 comment · Fixed by #535
Closed

Adding Symbol() as a field's value #405

n14little opened this issue May 18, 2020 · 1 comment · Fixed by #535
Labels
bug Something isn't working
Milestone

Comments

@n14little
Copy link
Contributor

n14little commented May 18, 2020

Describe the bug
Adding a Symbol() as a field's value panics with parsing failed: ParseIntError { kind: InvalidDigit }

To Reproduce
Add the following to tests/js/test.js

// tests/js/test.js
const obj = {
  x: 1,
  y: Symbol(),
  z: 3
};

and then run:

$ cargo run -- ./tests/js/test.js

Expected behavior
I would expect that the code successfully parse and not panic.

Build environment (please complete the following information):

  • OS: Ubuntu Linux
  • Version: 18.04
  • Target triple: x86_64-unknown-linux-gnu
  • Rustc version: rustc 1.43.1 (8d69840ab 2020-05-04)

Additional context
Add any other context about the problem here.

@n14little n14little added the bug Something isn't working label May 18, 2020
@n14little n14little changed the title Adding Symbol() as a field Adding Symbol() as a field May 18, 2020
@n14little n14little changed the title Adding Symbol() as a field Adding Symbol() as a field's value May 18, 2020
@n14little
Copy link
Contributor Author

Just put up a PR for this. The issue was fixed somewhere and the code in the PR just re-instates the ignored tests and then adds the branch for checking if a value is a symbol.

@Razican Razican modified the milestones: v0.9.0, v0.10.0 Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants