Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegExp.matchAll() returns an array, it should return an iterator #347

Closed
HalidOdat opened this issue Apr 26, 2020 · 3 comments
Closed

RegExp.matchAll() returns an array, it should return an iterator #347

HalidOdat opened this issue Apr 26, 2020 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@HalidOdat
Copy link
Member

No description provided.

@HalidOdat HalidOdat added bug Something isn't working help wanted Extra attention is needed labels Apr 26, 2020
@raskad
Copy link
Member

raskad commented Jul 19, 2021

This was fixed in #1350:

>> var a = /a/[Symbol.matchAll]("aaaaa");
undefined
>> typeof(a)
"object"
>> a
{
...
Symbol(Symbol.toStringTag): "RegExp String Iterator",
__proto__: {
Symbol(Symbol.iterator): {
          length: 0,
            name: "[Symbol.iterator]",
...
}

@Razican
Copy link
Member

Razican commented Jul 20, 2021

@HalidOdat I guess we can close this, right?

@Razican Razican added this to the v0.13.0 milestone Jul 20, 2021
@HalidOdat
Copy link
Member Author

@HalidOdat I guess we can close this, right?

yup :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants