Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASCII encoding JsStrings #3097

Closed
HalidOdat opened this issue Jul 2, 2023 · 0 comments · Fixed by #3450
Closed

ASCII encoding JsStrings #3097

HalidOdat opened this issue Jul 2, 2023 · 0 comments · Fixed by #3450
Assignees
@HalidOdat
Labels
API E-Hard Hard difficulty problem performance Performance related changes and issues

Comments

@HalidOdat
Copy link
Member

Currently JsString can only be u16 even if the contents can fit into the ASCII range this requires more memory to store strings.

It would be better to have a flag in JsString, to know if the data content is an array of u8 or u16.
@HalidOdat HalidOdat added performance Performance related changes and issues API E-Hard Hard difficulty problem labels Jul 2, 2023
@HalidOdat HalidOdat self-assigned this Nov 2, 2023
@HalidOdat HalidOdat mentioned this issue Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HalidOdat HalidOdat

Labels
API E-Hard Hard difficulty problem performance Performance related changes and issues
Projects
Boa pre-v1
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement latin1 encoded JsStrings boa-dev/boa
1 participant
@HalidOdat