deps: roll back http_parser to 2.3.0

Commit 598efcb ("deps: update http_parser to 2.4.1") introduced a
regression in HTTP Upgrade header handling.

Fixes: nodejs#627
PR-URL: nodejs#628
Reviewed-By: Fedor Indutny <[email protected]>

deps/http_parser/.gitignore

@@ -5,7 +5,6 @@ tags
 test
 test_g
 test_fast
-bench
 url_parser
 parsertrace
 parsertrace_g

deps/http_parser/.mailmap

@@ -5,4 +5,3 @@ Salman Haq <[email protected]>
 Simon Zimmermann <[email protected]>
 Thomas LE ROUX <[email protected]> LE ROUX Thomas <[email protected]>
 Thomas LE ROUX <[email protected]> Thomas LE ROUX <[email protected]>
-Fedor Indutny <[email protected]>

deps/http_parser/.travis.yml

@@ -10,4 +10,4 @@ script:
 notifications:
   email: false
   irc:
-    - "irc.freenode.net#node-ci"
+    - "irc.freenode.net#libuv"

deps/http_parser/AUTHORS

@@ -39,25 +39,12 @@ BogDan Vatra <[email protected]>
 Peter Faiman <[email protected]>
 Corey Richardson <[email protected]>
 Tóth Tamás <[email protected]>
+Patrik Stutz <[email protected]>
 Cam Swords <[email protected]>
 Chris Dickinson <[email protected]>
 Uli Köhler <[email protected]>
 Charlie Somerville <[email protected]>
-Patrik Stutz <[email protected]>
 Fedor Indutny <[email protected]>
 runner <[email protected]>
 Alexis Campailla <[email protected]>
 David Wragg <[email protected]>
-Vinnie Falco <[email protected]>
-Alex Butum <[email protected]>
-Rex Feng <[email protected]>
-Alex Kocharin <[email protected]>
-Mark Koopman <[email protected]>
-Helge Heß <[email protected]>
-Alexis La Goutte <[email protected]>
-George Miroshnykov <[email protected]>
-Maciej Małecki <[email protected]>
-Marc O'Morain <[email protected]>
-Jeff Pinner <[email protected]>
-Timothy J Fontaine <[email protected]>
-Akagi201 <[email protected]>

deps/http_parser/CONTRIBUTIONS

@@ -0,0 +1,4 @@
+Contributors must agree to the Contributor License Agreement before patches
+can be accepted.
+
+http://spreadsheets2.google.com/viewform?hl=en&formkey=dDJXOGUwbzlYaWM4cHN1MERwQS1CSnc6MQ

deps/http_parser/Makefile

@@ -19,25 +19,20 @@
 # IN THE SOFTWARE.
 
 PLATFORM ?= $(shell sh -c 'uname -s | tr "[A-Z]" "[a-z]"')
-SONAME ?= libhttp_parser.so.2.4.2
+SONAME ?= libhttp_parser.so.2.3
 
 CC?=gcc
 AR?=ar
 
-CPPFLAGS ?=
-LDFLAGS ?=
-
 CPPFLAGS += -I.
 CPPFLAGS_DEBUG = $(CPPFLAGS) -DHTTP_PARSER_STRICT=1
 CPPFLAGS_DEBUG += $(CPPFLAGS_DEBUG_EXTRA)
 CPPFLAGS_FAST = $(CPPFLAGS) -DHTTP_PARSER_STRICT=0
 CPPFLAGS_FAST += $(CPPFLAGS_FAST_EXTRA)
-CPPFLAGS_BENCH = $(CPPFLAGS_FAST)
 
 CFLAGS += -Wall -Wextra -Werror
 CFLAGS_DEBUG = $(CFLAGS) -O0 -g $(CFLAGS_DEBUG_EXTRA)
 CFLAGS_FAST = $(CFLAGS) -O3 $(CFLAGS_FAST_EXTRA)
-CFLAGS_BENCH = $(CFLAGS_FAST) -Wno-unused-parameter
 CFLAGS_LIB = $(CFLAGS_FAST) -fPIC
 
 LDFLAGS_LIB = $(LDFLAGS) -shared
@@ -66,12 +61,6 @@ test_fast: http_parser.o test.o http_parser.h
 test.o: test.c http_parser.h Makefile
 	$(CC) $(CPPFLAGS_FAST) $(CFLAGS_FAST) -c test.c -o $@
 
-bench: http_parser.o bench.o
-	$(CC) $(CFLAGS_BENCH) $(LDFLAGS) http_parser.o bench.o -o $@
-
-bench.o: bench.c http_parser.h Makefile
-	$(CC) $(CPPFLAGS_BENCH) $(CFLAGS_BENCH) -c bench.c -o $@
-
 http_parser.o: http_parser.c http_parser.h Makefile
 	$(CC) $(CPPFLAGS_FAST) $(CFLAGS_FAST) -c http_parser.c
 

deps/http_parser/README.md

@@ -61,7 +61,7 @@ if (recved < 0) {
 }
 
 /* Start up / continue the parser.
- * Note we pass recved==0 to signal that EOF has been received.
+ * Note we pass recved==0 to signal that EOF has been recieved.
  */
 nparsed = http_parser_execute(parser, &settings, buf, recved);
 
@@ -75,7 +75,7 @@ if (parser->upgrade) {
 HTTP needs to know where the end of the stream is. For example, sometimes
 servers send responses without Content-Length and expect the client to
 consume input (for the body) until EOF. To tell http_parser about EOF, give
-`0` as the fourth parameter to `http_parser_execute()`. Callbacks and errors
+`0` as the forth parameter to `http_parser_execute()`. Callbacks and errors
 can still be encountered during an EOF, so one must still be prepared
 to receive them.
 
@@ -110,7 +110,7 @@ followed by non-HTTP data.
 information the Web Socket protocol.)
 
 To support this, the parser will treat this as a normal HTTP message without a
-body, issuing both on_headers_complete and on_message_complete callbacks. However
+body. Issuing both on_headers_complete and on_message_complete callbacks. However
 http_parser_execute() will stop parsing at the end of the headers and return.
 
 The user is expected to check if `parser->upgrade` has been set to 1 after
@@ -131,7 +131,7 @@ There are two types of callbacks:
 * notification `typedef int (*http_cb) (http_parser*);`
     Callbacks: on_message_begin, on_headers_complete, on_message_complete.
 * data `typedef int (*http_data_cb) (http_parser*, const char *at, size_t length);`
-    Callbacks: (requests only) on_url,
+    Callbacks: (requests only) on_uri,
                (common) on_header_field, on_header_value, on_body;
 
 Callbacks must return 0 on success. Returning a non-zero value indicates
@@ -145,7 +145,7 @@ buffer to avoid copying memory around if this fits your application.
 
 Reading headers may be a tricky task if you read/parse headers partially.
 Basically, you need to remember whether last header callback was field or value
-and apply the following logic:
+and apply following logic:
 
     (on_header_field and on_header_value shortened to on_h_*)
      ------------------------ ------------ --------------------------------------------

deps/http_parser/contrib/parsertrace.c

@@ -111,22 +111,22 @@ int main(int argc, char* argv[]) {
   FILE* file = fopen(filename, "r");
   if (file == NULL) {
     perror("fopen");
-    goto fail;
+    return EXIT_FAILURE;
   }
 
   fseek(file, 0, SEEK_END);
   long file_length = ftell(file);
   if (file_length == -1) {
     perror("ftell");
-    goto fail;
+    return EXIT_FAILURE;
   }
   fseek(file, 0, SEEK_SET);
 
   char* data = malloc(file_length);
   if (fread(data, 1, file_length, file) != (size_t)file_length) {
     fprintf(stderr, "couldn't read entire file\n");
     free(data);
-    goto fail;
+    return EXIT_FAILURE;
   }
 
   http_parser_settings settings;
@@ -149,12 +149,8 @@ int main(int argc, char* argv[]) {
             "Error: %s (%s)\n",
             http_errno_description(HTTP_PARSER_ERRNO(&parser)),
             http_errno_name(HTTP_PARSER_ERRNO(&parser)));
-    goto fail;
+    return EXIT_FAILURE;
   }
 
   return EXIT_SUCCESS;
-
-fail:
-  fclose(file);
-  return EXIT_FAILURE;
 }