feat: cache lastTail in txindexer to avoid read from db #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
changed the title
owen-reorg
approved these changes
Sep 2, 2024
redhdx
approved these changes
Sep 2, 2024
bnoieh
pushed a commit
to bnoieh/op-geth
that referenced
this pull request
Nov 29, 2024
…_for_mainnet_superchains Bump the geth cache on OP stack mainnet chains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix
engine_forkchoiceUpdatedapi performance issue, which is introduced from upstream geth code.Rationale
engine_forkchoiceUpdatedapi blocks on chainHeadFeed.Send, which waits for all the feed subscribers to receive.rawdb.ReadTxIndexTail. You could find more details hereExample
n/a
Changes
lastTailintxindexer.goto avoid read from db