feat: restrict token transfers to payment accounts #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
force-pushed
the
restrict_payment
branch
from
120503d to
97f0d0e
Compare
yutianwu
changed the title
x/bank/keeper/msg_server.go
Outdated
| @@ -80,6 +88,12 @@ func (k msgServer) MultiSend(goCtx context.Context, msg *types.MsgMultiSend) (*t | |||
| if k.BlockedAddr(accAddr) { | |||
| return nil, sdkerrors.Wrapf(sdkerrors.ErrUnauthorized, "%s is not allowed to receive funds", out.Address) | |||
| } | |||
|
|
|||
| if ctx.IsUpgraded(upgradetypes.Nagqu) { | |||
There was a problem hiding this comment.
How about create a variable for ctx.IsUpgraded(upgradetypes.Nagqu) ? Then we do not need to re-calculate it in the loop.
forcodedancing
approved these changes
Aug 24, 2023
unclezoro
approved these changes
Aug 25, 2023
unclezoro
added a commit
that referenced
this pull request
Aug 29, 2023
This reverts commit 955fa2d.
This was referenced Aug 29, 2023
This was referenced Sep 6, 2023
This was referenced Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will restrict token transfers to payment accounts in greenfield.
The payment accounts are derived from the owner account with an index, the tokens transferred to the payment accounts will lost since there is no private key for the accounts. This pr will restrict direct token transfer to the payment accounts to prevent token lost.
Rationale
Restrict token transfers to payment accounts in greenfield.
Example
n/a
Changes
Notable changes: