Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: using abi.encode for update param tx #232

Merged
merged 2 commits into from
Jul 6, 2023
Merged

feat: using abi.encode for update param tx #232

merged 2 commits into from
Jul 6, 2023

Conversation

cosinlink
Copy link
Contributor

Description

replace rlp with ethereum abi.encode/decode in cross-chain update param

Rationale

for gas optimization

Changes

Notable changes:

  • replace rlp with ethereum abi.encode/decode in cross-chain update param
  • ...

@randyahx
Merge pull request #226 from bnb-chain/develop
d906f0e 
release: prepare release for v0.2.3-alpha.1
@pythonberg1997
Copy link
Contributor

Can we delete the bsc module since we don't need rlp any more?

@cosinlink
Copy link
Contributor Author

Can we delete the bsc module since we don't need rlp any more?

rlp is also used in the bls signing between relayers and gnfd nodes

@cosinlink cosinlink merged commit 2881155 into develop Jul 6, 2023
This was referenced Jul 13, 2023
Merged
Merged
@unclezoro unclezoro deleted the abiencode branch August 16, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pythonberg1997 pythonberg1997 pythonberg1997 approved these changes

@unclezoro unclezoro unclezoro approved these changes

@yutianwu yutianwu yutianwu approved these changes

Assignees
No one assigned
Labels
C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cosinlink @pythonberg1997 @yutianwu @unclezoro @randyahx