From c0ba54b0885a63dbe329de475edda3c0b3f887f1 Mon Sep 17 00:00:00 2001
From: Alexgao001 <alex.g@nodereal.io>
Date: Tue, 11 Apr 2023 12:31:44 +0800
Subject: [PATCH] make test passed

---
 x/gov/keeper/crosschain.go    |  3 ---
 x/gov/keeper/keeper_test.go   |  3 ++-
 x/gov/keeper/proposal_test.go | 16 ++++++++++++++--
 3 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/x/gov/keeper/crosschain.go b/x/gov/keeper/crosschain.go
index 0db579e0e0..bd4ca71d7d 100644
--- a/x/gov/keeper/crosschain.go
+++ b/x/gov/keeper/crosschain.go
@@ -16,7 +16,6 @@ func (k Keeper) RegisterCrossChainSyncParamsApp() error {
 }
 
 func (k Keeper) SyncParams(ctx sdk.Context, cpc govv1.CrossChainParamsChange) error {
-	// this validates content and size of changes is not empty
 	if err := cpc.ValidateBasic(); err != nil {
 		return err
 	}
@@ -67,8 +66,6 @@ func (k Keeper) SyncParams(ctx sdk.Context, cpc govv1.CrossChainParamsChange) er
 	return err
 }
 
-// Need these in order to register paramsKeeper to be a CrosschainApp so that it can register channel(3)
-
 func (k Keeper) ExecuteSynPackage(ctx sdk.Context, appCtx *sdk.CrossChainAppContext, payload []byte) sdk.ExecuteResult {
 	k.Logger(ctx).Error("received sync params sync package", "payload", hex.EncodeToString(payload))
 	return sdk.ExecuteResult{}
diff --git a/x/gov/keeper/keeper_test.go b/x/gov/keeper/keeper_test.go
index 03db4e8aeb..45d36c4e70 100644
--- a/x/gov/keeper/keeper_test.go
+++ b/x/gov/keeper/keeper_test.go
@@ -41,7 +41,7 @@ func (suite *KeeperTestSuite) SetupSuite() {
 }
 
 func (suite *KeeperTestSuite) reset() {
-	govKeeper, acctKeeper, bankKeeper, stakingKeeper, distKeeper, _, encCfg, ctx := setupGovKeeper(suite.T())
+	govKeeper, acctKeeper, bankKeeper, stakingKeeper, distKeeper, crossChainKeeper, encCfg, ctx := setupGovKeeper(suite.T())
 
 	// Populate the gov account with some coins, as the TestProposal we have
 	// is a MsgSend from the gov account.
@@ -64,6 +64,7 @@ func (suite *KeeperTestSuite) reset() {
 	suite.bankKeeper = bankKeeper
 	suite.stakingKeeper = stakingKeeper
 	suite.distKeeper = distKeeper
+	suite.crossChainKeeper = crossChainKeeper
 	suite.cdc = encCfg.Codec
 	suite.queryClient = queryClient
 	suite.legacyQueryClient = legacyQueryClient
diff --git a/x/gov/keeper/proposal_test.go b/x/gov/keeper/proposal_test.go
index 78b7f14343..5080671d4b 100644
--- a/x/gov/keeper/proposal_test.go
+++ b/x/gov/keeper/proposal_test.go
@@ -369,12 +369,24 @@ func (suite *KeeperTestSuite) TestUpdateCrossChainParams() {
 				Authority: suite.govKeeper.GetAuthority(),
 				Params: v1.CrossChainParamsChange{
 					Key:     "upgrade",
-					Values:  []string{"not_an_address", "not_an_address"},
-					Targets: []string{"not_an_address"},
+					Values:  []string{"0x76d244CE05c3De4BbC6fDd7F56379B145709ade9", "0xeAE67217D95E786a9309A363437066428b97c046"},
+					Targets: []string{"0xeAE67217D95E786a9309A363437066428b97c046"},
 				},
 			},
 			expectErr: true,
 		},
+		{
+			name: "single parameter change should work",
+			request: &v1.MsgUpdateCrossChainParams{
+				Authority: suite.govKeeper.GetAuthority(),
+				Params: v1.CrossChainParamsChange{
+					Key:     "param_1",
+					Values:  []string{"new_param_1"},
+					Targets: []string{"0x76d244CE05c3De4BbC6fDd7F56379B145709ade9"},
+				},
+			},
+			expectErr: false,
+		},
 	}
 
 	for _, tc := range testCases {