-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor gashub module #105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
reviewed
Feb 10, 2023
pythonberg1997
force-pushed
the
gashub
branch
from
February 13, 2023 07:03
f8d6b58
to
9e508ff
Compare
fynnss
reviewed
Feb 13, 2023
x/gashub/types/gas_calculator.go
Outdated
NewMsgGasParamsWithFixedGas("/bnbchain.greenfield.storage.MsgDeleteBucket", 1e5), | ||
NewMsgGasParamsWithFixedGas("/bnbchain.greenfield.storage.MsgDeleteGroup", 1e5), | ||
NewMsgGasParamsWithFixedGas("/bnbchain.greenfield.storage.MsgLeaveGroup", 1e5), | ||
NewMsgGasParamsWithFixedGas("/bnbchain.greenfield.storage.MsgRejectSealObject", 1e5), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message of payment module also need to be added here. @owen-reorg
owen-reorg
reviewed
Feb 13, 2023
owen-reorg
reviewed
Feb 13, 2023
owen-reorg
reviewed
Feb 13, 2023
The protobuf break-check CI can be disabled until we release the first public version |
unclezoro
reviewed
Feb 13, 2023
unclezoro
reviewed
Feb 13, 2023
unclezoro
reviewed
Feb 13, 2023
pythonberg1997
force-pushed
the
gashub
branch
from
February 14, 2023 08:23
f402cd9
to
5df1d26
Compare
pythonberg1997
force-pushed
the
gashub
branch
from
February 14, 2023 08:27
5df1d26
to
b7d9789
Compare
unclezoro
reviewed
Feb 14, 2023
unclezoro
reviewed
Feb 14, 2023
unclezoro
reviewed
Feb 14, 2023
pythonberg1997
force-pushed
the
gashub
branch
from
February 14, 2023 09:22
2ee554d
to
9b7ca1e
Compare
unclezoro
reviewed
Feb 14, 2023
unclezoro
reviewed
Feb 14, 2023
unclezoro
reviewed
Feb 14, 2023
unclezoro
reviewed
Feb 16, 2023
unclezoro
reviewed
Feb 16, 2023
unclezoro
reviewed
Feb 16, 2023
unclezoro
reviewed
Feb 16, 2023
unclezoro
reviewed
Feb 16, 2023
unclezoro
reviewed
Feb 16, 2023
unclezoro
approved these changes
Feb 16, 2023
Please fix the lint error and do integration test. |
This was referenced Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the gashub module.
Rationale
The previous implementation of gashub module had a lot of redundant code. To make it cleaner and easier to read, we refactor this module.
Example
Now the MsgGasParams is defined as below:
And update this paramSet should be done by the gov module.
Changes
Notable changes: