Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor gashub module #105

Merged
merged 13 commits into from
Feb 16, 2023
Merged

feat: refactor gashub module #105

merged 13 commits into from
Feb 16, 2023

Conversation

pythonberg1997
Copy link
Contributor

@pythonberg1997 pythonberg1997 commented Feb 10, 2023

Description

Refactor the gashub module.

Rationale

The previous implementation of gashub module had a lot of redundant code. To make it cleaner and easier to read, we refactor this module.

Example

Now the MsgGasParams is defined as below:
image

And update this paramSet should be done by the gov module.

Changes

Notable changes:

  • refactor gas params
  • add new msg for MsgGasParamsSet governance
  • add new tx fee check logic

@pythonberg1997 pythonberg1997 marked this pull request as ready for review February 13, 2023 06:52
NewMsgGasParamsWithFixedGas("/bnbchain.greenfield.storage.MsgDeleteBucket", 1e5),
NewMsgGasParamsWithFixedGas("/bnbchain.greenfield.storage.MsgDeleteGroup", 1e5),
NewMsgGasParamsWithFixedGas("/bnbchain.greenfield.storage.MsgLeaveGroup", 1e5),
NewMsgGasParamsWithFixedGas("/bnbchain.greenfield.storage.MsgRejectSealObject", 1e5),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message of payment module also need to be added here. @owen-reorg

@owen-reorg
Copy link

The protobuf break-check CI can be disabled until we release the first public version

client/tx/tx.go Outdated Show resolved Hide resolved
@unclezoro
Copy link
Collaborator

Please fix the lint error and do integration test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants