Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check generate and tidy in 'Build Test' ci #2794

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Dec 10, 2024

Description

ci: do more test in build ci

Rationale

do the following test in the build ci

check_tidy
check_generate
check_baddeps

if any one fails , the Build Test will fail

Example

if some one forget to modify gen_config.go after modifying eth/ethconfig/config.go,
Build Test will fail now

if some one forget to do go mod tidy after change go.mod,
Build Test will also fail

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 changed the base branch from master to develop December 10, 2024 08:07
@buddh0 buddh0 changed the title ci: do more test in build ci ci: do more test in Build Test ci Dec 10, 2024
@buddh0 buddh0 changed the title ci: do more test in Build Test ci ci: check generate and tidy in 'Build Test' ci Dec 11, 2024
@brilliant-lx brilliant-lx merged commit 1ee4b2e into bnb-chain:develop Dec 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants