Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compilation with Go 1.23 #2648

Closed
yorickdowne opened this issue Aug 14, 2024 · 3 comments
Closed

Support compilation with Go 1.23 #2648

yorickdowne opened this issue Aug 14, 2024 · 3 comments
Assignees

Comments

@yorickdowne
Copy link

Issue

Currently, compilation with Go 1.23 - the current version of Go - fails. Go 1.22 works.

151.2 github.com/prysmaticlabs/prysm/v5/validator/accounts
151.4 github.com/ethereum/go-ethereum/cmd/geth
153.1 # github.com/ethereum/go-ethereum/cmd/geth
153.1 link: github.com/fjl/memsize: invalid reference to runtime.stopTheWorld
153.4 util.go:48: exit status 1
153.4 exit status 1
153.5 make: *** [Makefile:16: geth] Error 1
@yorickdowne
Copy link
Author

Upstream: fjl/memsize#5

@yorickdowne
Copy link
Author

Go team rejected the memsize author’s proposal to make memsize work with Go 1.23.

Upstream go-ethereum fixed this by removing memsize in this patch: ethereum/go-ethereum@e467577

@zzzckck
Copy link
Collaborator

zzzckck commented Aug 15, 2024

Go team rejected the memsize author’s proposal to make memsize work with Go 1.23.

Upstream go-ethereum fixed this by removing memsize in this patch: ethereum/go-ethereum@e467577

@yorickdowne thank your feedback, we can pick this PR as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants