Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wanted] To refine the current BSC-eth67 implementation. #1522

Closed
brilliant-lx opened this issue Apr 25, 2023 · 0 comments
Closed

[wanted] To refine the current BSC-eth67 implementation. #1522

brilliant-lx opened this issue Apr 25, 2023 · 0 comments
Assignees
@BetZzzzz
Labels
X-network task filter for network issues, features, improve

Comments

@brilliant-lx
Copy link
Collaborator

brilliant-lx commented Apr 25, 2023 •
edited
Loading

Rationale

#412 introduced eth67 BSC extension.
But it could bring compatible issue, since it could break the eth67 protocol handshake if the other one does not support the eth67 bsc extension.

The relevant code:
610f6a5#diff-70b5045d8a974c1a2bc27ee96c7c8b42b5acc67b948b8b16084e24a9875b5ecb

Implementation

It is better not to break the current ETH67 protocol, to accept standard eth67 protocol.
@brilliant-lx brilliant-lx changed the title To refine the current BSC-eth67 implementation. [wanted] To refine the current BSC-eth67 implementation. May 9, 2023
@brilliant-lx brilliant-lx added the X-network task filter for network issues, features, improve label May 9, 2023
@zzzckck zzzckck closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BetZzzzz BetZzzzz

Labels
X-network task filter for network issues, features, improve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BetZzzzz @brilliant-lx @zzzckck