From 5d51873890f63c07442629487dea2202489c0ad3 Mon Sep 17 00:00:00 2001
From: Ng Wei Han <47109095+weiihann@users.noreply.github.com>
Date: Fri, 29 Mar 2024 15:06:54 +0800
Subject: [PATCH] p2p: add metrics for inbound/outbound peers (#2342)

---
 p2p/metrics.go | 6 +++++-
 p2p/server.go  | 5 +++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/p2p/metrics.go b/p2p/metrics.go
index c01a4be253..3b159e842e 100644
--- a/p2p/metrics.go
+++ b/p2p/metrics.go
@@ -37,7 +37,9 @@ const (
 )
 
 var (
-	activePeerGauge metrics.Gauge = metrics.NilGauge{}
+	activePeerGauge         metrics.Gauge = metrics.NilGauge{}
+	activeInboundPeerGauge  metrics.Gauge = metrics.NilGauge{}
+	activeOutboundPeerGauge metrics.Gauge = metrics.NilGauge{}
 
 	ingressTrafficMeter = metrics.NewRegisteredMeter("p2p/ingress", nil)
 	egressTrafficMeter  = metrics.NewRegisteredMeter("p2p/egress", nil)
@@ -74,6 +76,8 @@ func init() {
 	}
 
 	activePeerGauge = metrics.NewRegisteredGauge("p2p/peers", nil)
+	activeInboundPeerGauge = metrics.NewRegisteredGauge("p2p/peers/inbound", nil)
+	activeOutboundPeerGauge = metrics.NewRegisteredGauge("p2p/peers/outbound", nil)
 	serveMeter = metrics.NewRegisteredMeter("p2p/serves", nil)
 	serveSuccessMeter = metrics.NewRegisteredMeter("p2p/serves/success", nil)
 	dialMeter = metrics.NewRegisteredMeter("p2p/dials", nil)
diff --git a/p2p/server.go b/p2p/server.go
index 4d810aed66..aef27dcbfc 100644
--- a/p2p/server.go
+++ b/p2p/server.go
@@ -840,8 +840,10 @@ running:
 				if p.Inbound() {
 					inboundCount++
 					serveSuccessMeter.Mark(1)
+					activeInboundPeerGauge.Inc(1)
 				} else {
 					dialSuccessMeter.Mark(1)
+					activeOutboundPeerGauge.Inc(1)
 				}
 				activePeerGauge.Inc(1)
 			}
@@ -858,6 +860,9 @@ running:
 			srv.dialsched.peerRemoved(pd.rw)
 			if pd.Inbound() {
 				inboundCount--
+				activeInboundPeerGauge.Dec(1)
+			} else {
+				activeOutboundPeerGauge.Dec(1)
 			}
 			activePeerGauge.Dec(1)
 		}