From aa5f3e51518d649e0027f79ecfb096ef3a1a71c7 Mon Sep 17 00:00:00 2001 From: Luke Albao Date: Mon, 6 May 2024 18:17:21 -0700 Subject: [PATCH] test: unskip v8-updates/test-linux-perf-logger MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Refs: https://github.com/nodejs/node/issues/51308 Refs: https://github.com/nodejs/node/pull/52821 PR-URL: https://github.com/nodejs/node/pull/52869 Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Richard Lau Reviewed-By: Daeyeon Jeong --- test/v8-updates/test-linux-perf-logger.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/test/v8-updates/test-linux-perf-logger.js b/test/v8-updates/test-linux-perf-logger.js index ffea7257bbeae3..a2747b7c4282d1 100644 --- a/test/v8-updates/test-linux-perf-logger.js +++ b/test/v8-updates/test-linux-perf-logger.js @@ -20,7 +20,11 @@ // // NOTE: This test runs only on linux, as that is the only platform supported by perf, and // accordingly the only platform where `perf-basic-prof*` v8 flags are available. - +// +// MAINTAINERS' NOTE: As of early 2024, the most common failure mode for this test suite +// is for v8 options to change from version to version. If this suite fails, look there first. +// We use options to forcibly require certain test cases to JIT code, and the nodeFlags to do +// so can change. const common = require('../common'); if (!common.isLinux) { @@ -48,7 +52,8 @@ const testCases = [ }, { title: '--perf-basic-prof compiled', - nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan'], + nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan', + '--minimum-invocations-before-optimization=0'], matches: [ 'test-regex', '~functionOne .+/linux-perf-logger.js', @@ -66,7 +71,8 @@ const testCases = [ }, { title: '--perf-basic-prof-only-functions compiled', - nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan'], + nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan', + '--minimum-invocations-before-optimization=0'], matches: [ '~functionOne .+/linux-perf-logger.js', '~functionTwo .+/linux-perf-logger.js',