Design edits #1
Merged
Design edits #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly adding wrapper EUI page elements, but also shifted around form elements.
bmcconaghy
pushed a commit
that referenced
this pull request
Mar 13, 2019
* Prepare control flow to use embeddable factories in add panel * Rewrite saved object finder and add tests * Fix usages of new saved object finder * fix test failures * fix some functional tests and re-introduce makeUrl * fix tests * remove direct hrefs in saved_object_lists * PR review fixes * update snapshot * overwrite width of viz dialog * Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <[email protected]> * fix tests * review fixes #1 * review fixes #2 * dont use classname in functional test * remove call to action button prop * align buttons correctly * fix tests * remove debugging statement * Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js Co-Authored-By: flash1293 <[email protected]> * review fixes #3 * improve filter behavior and enable it for search wizard * adjust functional tests for new filter behavior * Change translation id due to string change * Update Jest snapshot
bmcconaghy
pushed a commit
that referenced
this pull request
Apr 2, 2019
* Prepare control flow to use embeddable factories in add panel * Rewrite saved object finder and add tests * Fix usages of new saved object finder * fix test failures * fix some functional tests and re-introduce makeUrl * fix tests * remove direct hrefs in saved_object_lists * PR review fixes * update snapshot * overwrite width of viz dialog * Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/discover/embeddable/search_embeddable_factory.ts Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/visualize/wizard/search_selection/search_selection.tsx Co-Authored-By: flash1293 <[email protected]> * fix tests * review fixes #1 * review fixes #2 * dont use classname in functional test * remove call to action button prop * align buttons correctly * fix tests * remove debugging statement * Update src/legacy/core_plugins/kibana/public/dashboard/top_nav/add_panel.js Co-Authored-By: flash1293 <[email protected]> * Update src/legacy/core_plugins/kibana/public/discover/top_nav/open_search_panel.js Co-Authored-By: flash1293 <[email protected]> * review fixes #3 * improve filter behavior and enable it for search wizard * adjust functional tests for new filter behavior * Change translation id due to string change * Update Jest snapshot
bmcconaghy
pushed a commit
that referenced
this pull request
Jun 26, 2019
* Introduce new convention for config definition. We need to define a way to acquire configuration schema as a part of plugin definition. Having schema we can split steps of config validation and plugin instantiation. * Discover plugins, read their schema and validate the config. Config validation finished before core services and plugins read from it. That allows us to fail fast and have predictable validation results. * Instantiate plugins using DiscoveredPluginsDefinitions. * Update tests for new API. * test server is not created if config validation fails * move plugin discovery to plugin service pre-setup stage. Set validation schemes in ConfigService.preSetup stage. * fix eslint problem * generate docs * address Rudolfs comments * separate core services and plugins validation * rename files for consistency * address comments for root.js * address comments #1 * useSchema everywhere for consistency. get rid of validateAll * plugin system runs plugin config validation * rename configDefinition * move plugin schema registration in plugins plugins service plugins system is not setup when kibana is run in optimizer mode, so config keys aren't marked as applied. * cleanup * update docs * address comments
bmcconaghy
pushed a commit
that referenced
this pull request
Jun 26, 2019
* unify modifyUrl on client and server * create BasePath as a separate entity on server * use BasePath class in http server * use BasePath a separate entity on client * use BasePath class on Http service on the client * switch client code to the new api * improve setver http service mocks * address comments #1 * address comments #2 * update docs * add comment why we define own typings
bmcconaghy
pushed a commit
that referenced
this pull request
Jun 26, 2019
* New and Legacy platforms share http server instance. Required to use a common security interceptor for incoming http requests * generate docs * remove excessive contract method * add test for New platform compatibility * address comments part #1 * log server running only for http server * fix test. mutate hapi request headers for BWC with legacy * return 503 on start * address @eli comments * address @joshdover comments
bmcconaghy
pushed a commit
that referenced
this pull request
Aug 12, 2019
* kbn top nav in discover * New top nav in dashboard and vis editor * change kbn top nav directive * Stop using template feature of kbn top nav * Combined css * console top nav * Removed unnecessary use of kbn-top-nav in dev tools app (wrapping tabs) * Changed console menu to new directive * CSS adjustments + functional implementation of top nav menu item * Fixed DevTools top nav toggle * Optional show-border * timelion menu works * Improve filter sorting logic to be more stable * Support showing filter bar as part of top nav * Use search bar in top nav in discover and maps Support search bar with no filter bar (TS) * tmp revert * Align search bar settings accross apps * Reverted change in ML, removed unused css * Added data test subj to top nav menu items * Watch config by value * Some directive magic to make sure that disabledButtons functions are watched correctly. * Fix missing controls from new top nav in some visualizations * showAutoRefreshOnly in input controls visualization * Fixed inspector disabled test * Fix dashboard action links rewrite top nav menu item to functional style * snapshots * Fixed maps filter bar * Remvoed comment * Update Query Bar defaults * Top nav menu item tests * Moved storage instantiation to angular directive * SearchBar jest tests * Query bar additional tests * Top nav menu tests * Pass store into top nav menu correctly * watch store by reference * Added not null assertion * Make index patterns optional (for timepicker only setup) * QueryBar tests again * Search bar tests * Top nav tests * Top nav menu tests * removed unnecessary ui/new_platform mock * Moved discover result count away from top nav * Moved and improved top nav menu css * remove unused translations * Move timepicker (to be deprecated) into old kbn_top_nav * Deleted search-bar and query-bar directives! * moved search bar to kibana_react (it's a generic react component, not a service) * translations * Moved superDatePicker directive to kbn_top_nav (to be deprecated) Deleted unused react_component directives call-out and tool-bar-search-box * Use index patterns from data plugin itself instead of importing from ui/public * Pass uiSettings from top level of data plugin * Pass saved objects client from top level * query bar input to rely on provided localStorage (?) * import QueryBarInput correctly from vis ediror * Query bar input tests - uiSettings * Query bar - uiSettings tests * import QueryBar from data plugin correctly * Use provider to pass config to TSVB query bar inputs * Add query bar input parms to agg types * Standardize shape data plugin and use it to pass uiSettings in. * Removed unnecessary mocks * Fixed test typo * Code review part 1 * Code review part 2 - clean up top nav menu item run interface * Give top nav items better keys * Simplified top nav construction logic in editor * Fixed mock of search bar in top nav test * Moved filter trigger button rendering to helper function * Remove responsiveness from top nav items * vertical align for cases where showSearchBarInline is true (i.e. only menu and time picker in the same row) * Export TopNavMenuData type * Removed unused name attribute in top nav. Use app-name instead. * Minor merge fixes * Update data plugin shape * type fixes * fix core start import * Fixed tests * fix another test mock * Brought back setup.ts for backward compatibility. Chnaged to relative imports * bad import from data plugin * Yet another import :-( * Code revire #1 @lukeelmers * create wrapper for QueryBarInput * use IndexPatterns type * import order * Code review fixes * inject uiSettings into filter-bar directive * Fix some type errors * Fixes * Filter bar context * ts CoreSetupContextProvider * Moved coreCOntext to vis_editor constructor * Reverted filter bar context * Removed editor html ng-show * use saved objects contract + check uiSettings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bmcconaghy
I thought it'd be faster just to do the design edits directly since it requires a lot of extra EUI components. But here is a quick design PR that is mainly about adding wrapper EUI page elements, but also shifting around form elements.