Check packed files for files suggestion

bluwy · Oct 9, 2023 · 167453a · 167453a
1 parent d47b807
commit 167453a
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 0 deletions.
diff --git a/pkg/src/index.js b/pkg/src/index.js
@@ -57,6 +57,12 @@ export async function publint({ pkgDir, vfs, level, strict, _packedFiles }) {
     promiseQueue.push(async () => {
       for (const p of commonInternalPaths) {
         const internalPath = vfs.pathJoin(pkgDir, p)
+        if (
+          _packedFiles &&
+          _packedFiles.every((f) => !f.startsWith(internalPath))
+        ) {
+          continue
+        }
         if (await vfs.isPathExist(internalPath)) {
           messages.push({
             code: 'USE_FILES',

diff --git a/pkg/tests/fixtures/npmignore/.npmignore b/pkg/tests/fixtures/npmignore/.npmignore
@@ -0,0 +1 @@
+tests
diff --git a/pkg/tests/fixtures/npmignore/main.js b/pkg/tests/fixtures/npmignore/main.js
@@ -0,0 +1 @@
+export const foo = 'This file is ESM, but extension says CJS'
diff --git a/pkg/tests/fixtures/npmignore/package.json b/pkg/tests/fixtures/npmignore/package.json
@@ -0,0 +1,7 @@
+{
+  "name": "publint-npmignore",
+  "version": "0.0.1",
+  "private": true,
+  "type": "module",
+  "exports": "./main.js"
+}
diff --git a/pkg/tests/fixtures/npmignore/tests/test.js b/pkg/tests/fixtures/npmignore/tests/test.js
@@ -0,0 +1 @@
+// suggest pkg.files if this file is published
diff --git a/pkg/tests/playground.js b/pkg/tests/playground.js
@@ -47,6 +47,8 @@ testFixture('exports-module', ['EXPORTS_MODULE_SHOULD_PRECEDE_REQUIRE'])
 
 testFixture('publish-config', ['FILE_DOES_NOT_EXIST', 'USE_EXPORTS_BROWSER'])
 
+testFixture('npmignore', [])
+
 testFixture('test-1', [
   'FILE_INVALID_FORMAT',
   'TYPES_NOT_EXPORTED',
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		export const foo = 'This file is ESM, but extension says CJS'