Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE - Image Upload Component #1731

Open
ajhollid opened this issue Feb 9, 2025 · 7 comments
Open

FE - Image Upload Component #1731

ajhollid opened this issue Feb 9, 2025 · 7 comments
Assignees

Comments

@ajhollid
Copy link
Collaborator

ajhollid commented Feb 9, 2025

We have several components for uploading images. We should have one unified component

It should

  1. Have a preview of image uploaded
  2. Have a loading state while image is uploading
  3. Have a button for removing current image
  4. Accept only images, provide basic validation
  5. Have a max file upload size

The API should look something like this:

<ImageUpload
    onChange={updateImage}
    onError={handleImageUploadError}
    value={img}
    maxSize={3000000}
    acceptedTypes={acceptedTypes}
    previewSize={200}
/>

This API is a suggestion and not a hard requirement.

@gorkem-bwl if you have time a Figma of an ideal upload component would be helpful!

@Br0wnHammer
Copy link
Contributor

@gorkem-bwl @ajhollid Can I take this on? If it is not much of a complex task?

@ajhollid
Copy link
Collaborator Author

ajhollid commented Feb 9, 2025

Hey @Br0wnHammer ,

This is a mission critical component so will be assigned to one of the internal team members.

Thanks for your interest with this one though!

@Br0wnHammer
Copy link
Contributor

Hey @Br0wnHammer ,

This is a mission critical component so will be assigned to one of the internal team members.

Thanks for your interest with this one though!

No worries.

@gorkem-bwl gorkem-bwl self-assigned this Feb 9, 2025
@vishnusn77
Copy link

@ajhollid @gorkem-bwl Can I work on this?

@ajhollid
Copy link
Collaborator Author

@vishnusn77 as mentioned above this will be handled by an internal team member, thanks for your interest though! There will be more issues coming up

@ajhollid
Copy link
Collaborator Author

@ajhollid @gorkem-bwl Can I work on this?

@vishnusn77 sorry I didn't realize you are our @vishnusn77 😂

@vishnusn77
Copy link

@vishnusn77 sorry I didn't realize you are our @vishnusn77 😂

@ajhollid no worries lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants