Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can this code be removed? #753

Open
coretl opened this issue Jan 28, 2025 · 1 comment
Open

Can this code be removed? #753

coretl opened this issue Jan 28, 2025 · 1 comment
Assignees

Comments

@coretl
Copy link
Collaborator

coretl commented Jan 28, 2025

Can we remove this?

if self._include_file_number:
self._filename_template += "_%6.6d"

Doesn't seem to be used anywhere...

Acceptance Criteria

  • Line is removed or explained
@jwlodek
Copy link
Member

jwlodek commented Jan 28, 2025

This was meant to offer the option of adding the file counter to the end of the hdf file name, but now that I think about it, we reset the counter on closing the writer - we should probably just have the filename provider handle this for us instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants