Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6-circle drawing is mislabeled #324

Open
prjemian opened this issue Mar 4, 2024 · 3 comments
Open

6-circle drawing is mislabeled #324

prjemian opened this issue Mar 4, 2024 · 3 comments

Comments

@prjemian
Copy link
Contributor

prjemian commented Mar 4, 2024

The drawing used with the TARDIS example is mislabeled as E6C. Clearly it is not since mu is not part of the detector stack in the E6C geometry. The drawing is correct for the SPEC sixc geometry which is the IUCr 6-circle geometry.

image

The drawing should be psic (the geometry described by Hoydoo Yoo's paper).

Confirm all this before proceeding.

@prjemian
Copy link
Contributor Author

prjemian commented Mar 4, 2024

This is the drawing and description of E6C, from (a private copy of) the libhkl documentation
image

@prjemian
Copy link
Contributor Author

prjemian commented Mar 4, 2024

The PETRA3 P09 EH2 libhkl geometry matches the figure above:
image

@ambarb
Copy link

ambarb commented May 16, 2024

@prjemian i confirm that the tardis is sixc and we also identified this (hkl-engine-petra3-p09-eh2.c) as the correct picca set of circles.

we ran into some problems when adding a 4th axis so there may still be so circle direction inversion but we are not in a position to resolve that. If we go back to the 4th axis, we will start with this engine (hkl-engine-petra3-p09-eh2.c)

we use the following 3 axes now: omega (theta in sixc), delta, gamma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants