Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Search to separate component for searching runs and component for drilling into nested catalogs #62

Open
danielballan opened this issue Dec 2, 2020 · 1 comment
Assignees

Comments

@danielballan
Copy link
Member

The current implementation of the model Search could be described as:

  • Search IS a model for drilling down into nested catalogs.
  • Search HAS a model for searching catalogs of runs (RunSearch).

Proposal:

  • Make RunSearch a separately useful component. It's only part of the way there at present.
  • Make a separate model for drilling down into nested catalogs as a stand-alone thing.
  • Combine by composition in a small "drill down and then search" model.
@danielballan
Copy link
Member Author

As part of this work, make it possible to pass custom search fields into Search and thread them down to SearchInput. Currently there is no way to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant