Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threading issues with mongo server timeout #25

Open
2 of 3 tasks
dylanmcreynolds opened this issue Oct 1, 2020 · 2 comments · May be fixed by #27
Open
2 of 3 tasks

Threading issues with mongo server timeout #25

dylanmcreynolds opened this issue Oct 1, 2020 · 2 comments · May be fixed by #27
Labels
bug Something isn't working

Comments

@dylanmcreynolds
Copy link

dylanmcreynolds commented Oct 1, 2020

In the relatively short period of time when the databroker browers was in xicam.gui, I spent some time trying to make it so that searching a catalog for runs didn't block xicam's main thread, and gave some notice to the user in the status bar about what was going on, with a progress bar (what I did needed improvement, for sure.) Now that it's back to using bluesky-widgets, I'm seeing some issues with the new bluesky-widgets code in xicam.

While waiting for a mongo server timeout to occur, I see two issues:

  • xicam is locked up, which indicates to me that something is blocking the main thread
  • when the timeout does occur and control comes back xicam, the catalog selection dropdown does not re-enable, making it hard to try a different catalog.
  • same locking issue when the user clicks "Open" on a catalog
@danielballan danielballan linked a pull request Oct 1, 2020 that will close this issue
@danielballan
Copy link
Member

I believe that #27 addresses the first two items. The third item is still in the Xi-CAM layer; the bluesky-widgets component does not provide any Open button.

Taking just a quick look at the changes when I refactored to introduce the bluesky-widgets dependency (https://github.com/Xi-CAM/Xi-cam/pull/14/files#diff-334e756e951ddde184edaa4b5ebad6deL50-R117) I don't think anything was substantially changed there. Are we sure this didn't lock up before?

@dylanmcreynolds
Copy link
Author

Agreed... one and two are fixed by your PR, and I the third is a xicam thing.

@danielballan danielballan added the bug Something isn't working label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants