Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit start-re-manager CLI parameterization #150

Open
danielballan opened this issue Apr 15, 2021 · 1 comment
Open

Revisit start-re-manager CLI parameterization #150

danielballan opened this issue Apr 15, 2021 · 1 comment

Comments

@danielballan
Copy link
Member

Looking to other examples for inspiration, it might make sense to replace --zmq-addr with separate parameters:

--hostname (localhost by default)
--port (conventional default port by default)
--protocol (tcp by default, but in the future ssl, ucx?)

If we are concerned with backward-compatible for our small userbase, we can still support --zmq-addr for a time.

@danielballan
Copy link
Member Author

Regarding our discussion about addr vs address, I think the default behavior of argparse will let both be happy. By default, it tolerates abbreviations as long as they are unambigous: https://docs.python.org/3/library/argparse.html#allow-abbrev

Thus, we can use ...-address if/when it comes up but ...-addr will also work, as a general feature of argparse. (Many, though not all, UNIX utilities work this way too.) @jklynch has made me a zealot for clear, reader-oriented naming schemes. :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant