Share menu #7840
Open
Share menu #7840
+779
−413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
arcalinea
temporarily deployed
to
samuel/share-menu - social-app PR #7840
Render
Destroyed
This reverts commit 4174490.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New share menu! Declutters the enormous post dropdown
This PR also renames and reorganises the post controls, and creates a base button component which all the post controls can use - beforehand, it was a complete mess and icons were all different sizes etc
Stacked:
New button
Share menu
Post dropdown (discover)
Post downdown (own post)
Dev mode goes into the share menu
Test plan
Press all the buttons
Confirm post ctrls are all still working and aligned properly
Confirm I put the right items in the right menus