-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amharic translation #6618
base: main
Are you sure you want to change the base?
Amharic translation #6618
Conversation
Awesome! Is there anybody available to review this translation? |
@@ -40,6 +40,10 @@ import {useLanguagePrefs} from '#/state/preferences' | |||
*/ | |||
export async function dynamicActivate(locale: AppLanguage) { | |||
switch (locale) { | |||
case AppLanguage.am: { | |||
i18n.loadAndActivate({locale, messages: messagesAm}) | |||
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break | |
await Promise.all([ | |
import('@formatjs/intl-pluralrules/locale-data/am'), | |
import('@formatjs/intl-numberformat/locale-data/am'), | |
]) | |
break |
I checked and both formatjs/intl-pluralrules
and formatjs/intl-numberformat
support the am
locale:
https://www.npmjs.com/package/@formatjs/intl-pluralrules?activeTab=code
https://www.npmjs.com/package/@formatjs/intl-numberformat?activeTab=code
So I think these lines can be added :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks i will add those.
Apart from the change mentioned above, one other technical change would be needed to enable the Amharic localization in the app. Could you please add this line – assuming I got the endonym for Amharic right, I copied it from Wikipedia – above the Catalan entry:
social-app/src/locale/languages.ts Line 40 in 0c404f6
|
Hi, i have made Bluesky translations for amharic.
Attachments
No response
Describe Alternatives
No response
Additional Context
No response