Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amharic translation #6618

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Howmuchadollarcost
Copy link

Hi, i have made Bluesky translations for amharic.

Attachments

No response

Describe Alternatives

No response

Additional Context

No response

@pfrazee
Copy link
Collaborator

pfrazee commented Nov 23, 2024

Awesome! Is there anybody available to review this translation?

@@ -40,6 +40,10 @@ import {useLanguagePrefs} from '#/state/preferences'
*/
export async function dynamicActivate(locale: AppLanguage) {
switch (locale) {
case AppLanguage.am: {
i18n.loadAndActivate({locale, messages: messagesAm})
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
break
await Promise.all([
import('@formatjs/intl-pluralrules/locale-data/am'),
import('@formatjs/intl-numberformat/locale-data/am'),
])
break

I checked and both formatjs/intl-pluralrules and formatjs/intl-numberformat support the am locale:

https://www.npmjs.com/package/@formatjs/intl-pluralrules?activeTab=code

https://www.npmjs.com/package/@formatjs/intl-numberformat?activeTab=code

So I think these lines can be added :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks i will add those.

@surfdude29
Copy link
Contributor

Apart from the change mentioned above, one other technical change would be needed to enable the Amharic localization in the app.

Could you please add this line – assuming I got the endonym for Amharic right, I copied it from Wikipedia – above the Catalan entry:

{code2: AppLanguage.am, name: 'አማርኛ – Amharic'},

{code2: AppLanguage.ca, name: 'Català – Catalan'},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants