Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification time spacing #6109

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix notification time spacing #6109

merged 1 commit into from
Nov 4, 2024

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Nov 4, 2024

#5550 switched the spacing around the middot from whitespace characters to margins. Unfortunately this does not work, I'm unsure why - but it would definitely not work with text scaling, so probably best not to use it even if it did work.

This reverts it to just use whitespace again

@arcalinea arcalinea temporarily deployed to samuel/middot-spacing - social-app PR #6109 November 4, 2024 21:37 — with Render Destroyed
@mozzius mozzius changed the title return to using whitespace Fix notification time spacing Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

Old size New size Diff
8.12 MB 8.12 MB -16 B (-0.00%)

@@ -451,8 +451,9 @@ let FeedItem = ({
<TimeElapsed timestamp={item.notification.indexedAt}>
{({timeElapsed}) => (
<>
<Text style={[a.ml_xs, pal.textLight]}>&middot;</Text>
<Text style={[a.ml_xs, pal.textLight]} title={niceTimestamp}>
{/* make sure there's whitespace around the middot -sfn */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you can <Text style={[pal.textLight]}>{' '}&middot;{' '}</Text> to make it explicit if you'd like

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote that - prettier removed it!

@mozzius mozzius merged commit ab4e361 into main Nov 4, 2024
6 checks passed
@mozzius mozzius deleted the samuel/middot-spacing branch November 4, 2024 21:47
gaearon pushed a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants