Support params-only searches #5767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
search-params - social-app PR #5767
Render
Destroyed
|
haileyok
approved these changes
Oct 15, 2024
haileyok
pushed a commit
that referenced
this pull request
Oct 15, 2024
(cherry picked from commit fe5eb50)
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5737
Previous logic was showing the Explore page if
querywas falsy, butqueryWithParamsis really the new source of truth for if the user has searched for something.So this PR uses
queryWithParamsto determine if results should be shown. If params are present in the search query, this PR hides the "People" and "Feeds" tabs, which don't support params anyway.Example searches
eric— shows all 4 tabsfrom:esb.lol— shows only first 2 tabsfrom:esb.lol javascript— shows only first 2 tabs