Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pino dependency #6679

Open
trivikr opened this issue Nov 24, 2024 · 0 comments · May be fixed by #6681
Open

Remove unused pino dependency #6679

trivikr opened this issue Nov 24, 2024 · 0 comments · May be fixed by #6681
Labels
feature-request A request for a new feature

Comments

@trivikr
Copy link
Contributor

trivikr commented Nov 24, 2024

Describe the Feature

The dependency https://www.npmjs.com/package/pino is a very low overhead Node.js logger.
It seems to be added in in dependencies, but it's not used.
https://github.com/search?q=repo%3Abluesky-social%2Fsocial-app%20pino&type=code

Here's how to use is with express https://github.com/pinojs/pino/blob/HEAD/docs/web.md#pino-with-express for example

const app = require('express')()
const pino = require('pino-http')()

app.use(pino)

app.get('/', function (req, res) {
  req.log.info('something')
  res.send('hello world')
})

app.listen(3000)

It looks like the code was copied from the backend
https://github.com/search?q=repo%3Abluesky-social%2Fatproto%20pino&type=code, and the pino dependency can be removed.

Attachments

No response

Describe Alternatives

No response

Additional Context

No response

@trivikr trivikr added the feature-request A request for a new feature label Nov 24, 2024
@trivikr trivikr linked a pull request Nov 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant