New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or disable pnpm warning "There are cyclic workspace dependencies" #3009

Open

trivikr opened this issue Nov 15, 2024 · 1 comment · May be fixed by #3010

trivikr commented Nov 15, 2024

Is your feature request related to a problem? Please describe.

Running make deps shows the following warning

 WARN  There are cyclic workspace dependencies: /Users/trivikram/workspace/atproto/packages/bsky, /Users/trivikram/workspace/atproto/packages/pds

This happens as the two packages are dependent on each other:

bsky has pds as a devDependency:

atproto/packages/bsky/package.json

Line 68 in c34426f

"@atproto/pds": "workspace:^",
pds has bsky as a devDependency

atproto/packages/pds/package.json

Line 75 in c34426f

"@atproto/bsky": "workspace:^",

Describe the solution you'd like

Investigate if the cyclic dependency can be removed.

If yes, remove the cyclic dependency. This is recommended solution.
If no, set ignore-workspace-cycles to true in .npmrc so that the warning is not shown.

The text was updated successfully, but these errors were encountered:

Author

trivikr commented Nov 15, 2024

From looking at the code, it looks like devDependency of @atproto/bsky is not used in pds and can be removed.

https://github.com/search?q=repo%3Abluesky-social%2Fatproto+%27%40atproto%2Fbsky%27+path%3Apackages%2Fpds&type=code

trivikr linked a pull request

that will close this issue

Remove devDep '@atproto/bsky' from pds #3010

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment