Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub Actions For Other Sections #10

Open
LukePrior opened this issue Mar 11, 2022 · 6 comments
Open

Create GitHub Actions For Other Sections #10

LukePrior opened this issue Mar 11, 2022 · 6 comments
Assignees
Labels
hardware Code for microcontroller / RPi on groundstation hardware orchestration Issues related to the central orchestrator backend sigproc Issue related to signal processing service

Comments

@LukePrior
Copy link
Contributor

This is a bit of a personal preference and not an immediate priority but I think it would be good to set up automated style and build checks for orchestration, hardware, and possibly signal processing.

The frontend checks are run for every pull request and push that includes changes to any files with the frontend folder.

I envision something similar to this for the other sections with the checks customised to the specific requirements, e.g. pylint, etc

@LukePrior LukePrior added hardware Code for microcontroller / RPi on groundstation hardware orchestration Issues related to the central orchestrator backend sigproc Issue related to signal processing service labels Mar 11, 2022
@LukePrior
Copy link
Contributor Author

This has been done for orchestration with #13

@LukePrior LukePrior self-assigned this Mar 16, 2022
@LukePrior
Copy link
Contributor Author

Hardware ToDo:

@Finchiedev
Copy link

Should we set up a script runner (I have used Just on some personal projects) so that everything can be managed from the top-level directory without needing to understand the different projects?

@LukePrior
Copy link
Contributor Author

The frontend actions need to be updated as we move to React.

  • The HTML lint can be removed.
  • The TypeScript lint can be updated to also lint the TSX files.
  • The TypeScript lint need the eslint-plugin-react package added.
  • The TypeScript lint configuration file will need updating.
  • The lighthouse configuration file might need updating.

@LukePrior
Copy link
Contributor Author

Ok the frontend GitHub Actions has now been updated.

@LukePrior
Copy link
Contributor Author

It looks like we might now be using platformio for hardware. We can use the Platform IO CLI to test that the software can successfully be built for our target board.

https://docs.platformio.org/en/stable/integration/ci/github-actions.html

Depending on what language is ultimately chosen for programming of the Arduino a suitable style linter can also be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hardware Code for microcontroller / RPi on groundstation hardware orchestration Issues related to the central orchestrator backend sigproc Issue related to signal processing service
Projects
None yet
Development

No branches or pull requests

2 participants