Fix PWM #86
Merged
Fix PWM #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
fix-pwm
branch
from
4de574f to
d5fa8c9
Compare
| pin.set_direction(Direction::Low)?; | ||
| pin.set_direction(Direction::High)?; |
There was a problem hiding this comment.
I was wondering what a low/high direction even means, here it is:
"direction" ... reads as either "in" or "out". This value may
normally be written. Writing as "out" defaults to
initializing the value as low. To ensure glitch free
operation, values "low" and "high" may be written to
configure the GPIO as an output with that initial value.
So here we are configuring the pin to be an output with the initial state as high.
There was a problem hiding this comment.
joaoantoniocardoso
approved these changes
Nov 27, 2024
RaulTrombin
requested changes
Nov 27, 2024
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
fix-pwm
branch
2 times, most recently
from
530ab88 to
eb01016
Compare
RaulTrombin
approved these changes
Nov 27, 2024
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
fix-pwm
branch
from
3e37d60 to
d4f1f47
Compare
| let mut imu = Icm20689Device::builder().build().unwrap(); | ||
| let mut imu = Icm20689Device::builder() | ||
| .build() | ||
| .expect("Failed to build ICM20689: {error:?}"); |
There was a problem hiding this comment.
oh, this should be fixed to "Failed to build ICM20689", as this is not a formatted string, same for the others. The error message is automatically shown by the underlying unwrap mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.