Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in mavlink2resthelper #5

Closed
R-Stokke opened this issue Jun 17, 2022 · 1 comment · Fixed by #11
Closed

Bugs in mavlink2resthelper #5

R-Stokke opened this issue Jun 17, 2022 · 1 comment · Fixed by #11
Labels
bug Something isn't working

Comments

@R-Stokke
Copy link

Discovered two bugs in the mavlink2resthelper.py file:

  1. Import in line 1 references companionhelper, should be blueoshelper.

  2. The GET requests in line 175 and 186 are failing due to incomplete paths, likely due to BlueOS using a newer mavlink2rest version. Can be fixed by adding the constant:
    PATH_PREFIX = "/vehicles/1/components/1/messages"

And updating the aforementioned lines to:
response = request(MAVLINK2REST_URL + '/mavlink' + PATH_PREFIX + path)

Ideally the path prefix should allow for accessing different vehicle and components IDs, unsure how to best implement this.

@patrickelectric
Copy link
Member

patrickelectric commented Jun 20, 2022

Hi @R-Stokke, the first issue is already fixed on the latest version of master branch.
About the support of the latest version of BlueOS, that issue still exist.
The second one appears to still exist. Be free to send a pull request with the necessary corrections, we right now are without time for the following days.
For the vehicle ID, I would recommend for now to access it as argument with argparse.

@patrickelectric patrickelectric added the bug Something isn't working label Jun 20, 2022
@Williangalvani Williangalvani mentioned this issue Aug 8, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants