From 7df66a4f25cc91b3193ba4cf8623f38331b6ab61 Mon Sep 17 00:00:00 2001 From: Chris Wegrzyn Date: Fri, 2 Apr 2021 12:54:48 -0400 Subject: [PATCH] Restrict sqlalchemy to version 1.3.x 1.4 introduces a number of breaking changes and isn't compatible with all sqlalchemy extensions (e.g., bigquery) --- setup.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/setup.py b/setup.py index f8d50760d..d6945847e 100755 --- a/setup.py +++ b/setup.py @@ -140,14 +140,14 @@ def initialize_options(self) -> None: ] db_dependencies = [ - # Without this, pip 2.20.4 with "--use-feature=2020-resolver" will - # try to install every version of SQLAlchemy while trying to solve a - # dependency conflict. + # Lower bound (>=1.3.18) is to improve package resolution performance # - # Also, pipgrip (used to make Python formulas in Homebrew) takes - # somewhere between much longer and forever to provide its output - # without this line. - 'sqlalchemy>=1.3.18', + # Upper bound (<1.4) is to avoid 1.4 which has breaking changes and is + # incompatible with python-bigquery-sqlalchemy per + # https://github.com/googleapis/python-bigquery-sqlalchemy/issues/83 + # Can lift this once records-mover itself is compatible and + # other packages have appropriate restrictions in place. + 'sqlalchemy>=1.3.18,<1.4', ] smart_open_dependencies = [