Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more datetimefomat/datetimeformattz hints on Pandas output #143

Closed
vinceatbluelabs opened this issue Dec 9, 2020 · 0 comments · Fixed by #155
Closed

Support more datetimefomat/datetimeformattz hints on Pandas output #143

vinceatbluelabs opened this issue Dec 9, 2020 · 0 comments · Fixed by #155

Comments

@vinceatbluelabs
Copy link
Contributor

vinceatbluelabs commented Dec 9, 2020

The current datetimefomat/datetimeformattz hint support in to_csv_options.py is limited to ISO format driven by the dateformat hint. This could be generalized to a smarter function which translates to from the Records Spec language into the Python/Pandas/strftime format, and reject fewer hints as a result.

Another example of having an overly simplistic implementation of to_csv_options is that seconds get appended even for time formats which don't include it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant