diff --git a/records_mover/db/redshift/records_copy.py b/records_mover/db/redshift/records_copy.py index 575a0fc1d..a95baf66a 100644 --- a/records_mover/db/redshift/records_copy.py +++ b/records_mover/db/redshift/records_copy.py @@ -13,7 +13,7 @@ class RedshiftCopyParamaters: def __init__(self, - records_format: BaseRecordsFormat, + records_format: DelimitedRecordsFormat, fail_if_cant_handle_hint: bool, unhandled_hints: Set[str]): self.redshift_options: RedshiftCopyOptions = {} @@ -32,10 +32,10 @@ def process_compression(redshift_options: RedshiftCopyOptions, 'BZIP': Compression.bzip2, None: None } - - compression = compression_map.get(hints.compression) - if compression is None and hints.compression is not None: - _assert_never(hints.compression) + hints_compression: Optional[str] = hints.compression + compression = compression_map.get(hints_compression) + if compression is None and hints_compression is not None: + _assert_never(hints_compression) else: redshift_options['compression'] = compression quiet_remove(unhandled_hints, 'compression') @@ -204,7 +204,7 @@ def redshift_copy_options(unhandled_hints: Set[str], fail_if_cant_handle_hint: bool, fail_if_row_invalid: bool, max_failure_rows: Optional[int]) -> RedshiftCopyOptions: - redshift_options: RedshiftCopyOptions() = dict() + redshift_options: RedshiftCopyOptions = dict() if isinstance(records_format, AvroRecordsFormat): redshift_options['format'] = Format.avro diff --git a/records_mover/records/targets/fileobj.py b/records_mover/records/targets/fileobj.py index db59b633b..1aa93ba9d 100644 --- a/records_mover/records/targets/fileobj.py +++ b/records_mover/records/targets/fileobj.py @@ -74,8 +74,7 @@ def write_dfs(path_or_buf: Union[str, IO[str]]) -> int: move_count = write_dfs(text_fileobj) text_fileobj.detach() else: - with NamedTemporaryFile(prefix='mover_fileobj_target') as output_file: - move_count = write_dfs(output_file.name) + with NamedTemporaryFile(prefix='mover_fileobj_target') as output_file: # noqa with open(output_file.name, "rb") as output_fileobj: copyfileobj(output_fileobj, self.fileobj)