Skip to content

Commit

Permalink
[Journeys] Fix position of optout menu item
Browse files Browse the repository at this point in the history
Its visibility won't be controlled properly unless it's in the "normal"
group.

(cherry picked from commit 481cc63)

Bug: 1303171, 1346697
Change-Id: I3eb9134f3367ef63a602b6e9a7d7b68c71695521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3781007
Reviewed-by: Ted Choc <[email protected]>
Reviewed-by: Gang Wu <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1027867}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3788396
Reviewed-by: Krishna Govind <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Owners-Override: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/5195@{#58}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
  • Loading branch information
Patrick Noland authored and Chromium LUCI CQ committed Jul 27, 2022
1 parent 4f6dca8 commit cf9a3d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chrome/android/java/res/menu/history_manager_menu.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@
android:title="@string/close"
app:showAsAction="ifRoom"
app:iconTint="@color/default_icon_color_secondary_tint_list" />
</group>
<item
android:id="@+id/optout_menu_id"
android:title="@string/history_clusters_disable_menu_item_label"
android:visible="false"
app:showAsAction="never" />
</group>
<group
android:id="@+id/selection_mode_menu_group"
android:visible="false" >
Expand Down

0 comments on commit cf9a3d0

Please sign in to comment.