From cbd450203dec611180b020656ae1e82d925d1009 Mon Sep 17 00:00:00 2001 From: Donn Denman Date: Tue, 10 Mar 2020 01:07:03 +0000 Subject: [PATCH] Revert "[TTS] Reenable CSMTest suite with longer timeout." This reverts commit a5ef8671093abb25a2f15626e829fa0b299e6263. Reason for revert: Still flaking a lot. Original change's description: > [TTS] Reenable CSMTest suite with longer timeout. > > Speculatively re-enables the ContextualSearchManagerTest suite with > the hope that the mysterious underlying flakiness issue has gone > away, or that the longer timeout in this version of the code will > help. > > Original disabling CL: https://crrev.com/c/2088007 > > TBR=twellington@chromium.org > > BUG=1058362 > > Change-Id: I02ea4f209b86b730cc6f40622839ffb12f3753c7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094245 > Commit-Queue: Donn Denman > Reviewed-by: Donn Denman > Cr-Commit-Position: refs/heads/master@{#748287} TBR=donnd@chromium.org,twellington@chromium.org Change-Id: Ibb00c69f96bf4bbc54776540c813e68f86598fc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095963 Reviewed-by: Donn Denman Commit-Queue: Donn Denman Cr-Commit-Position: refs/heads/master@{#748464} --- .../contextualsearch/ContextualSearchManagerTest.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java index 280b6d3750ee63..4145ffb3a9a9a3 100644 --- a/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java +++ b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java @@ -125,6 +125,11 @@ "disable-features=" + ChromeFeatureList.CONTEXTUAL_SEARCH_ML_TAP_SUPPRESSION}) @Restriction(RESTRICTION_TYPE_NON_LOW_END_DEVICE) @RetryOnFailure +// +// NOTE -- THIS WHOLE TEST CLASS IS TEMPORARILY DISABLED: +// +@DisabledTest(message = "See https://crbug.com/1058362") +// public class ContextualSearchManagerTest { @Rule public ChromeActivityTestRule mActivityTestRule = @@ -142,7 +147,7 @@ public class ContextualSearchManagerTest { private static final String LOW_PRIORITY_INVALID_SEARCH_ENDPOINT = "/s/invalid"; private static final String CONTEXTUAL_SEARCH_PREFETCH_PARAM = "&pf=c"; // The number of ms to delay startup for all tests. - private static final int ACTIVITY_STARTUP_DELAY_MS = 5000; // TODO(donnd): reduce! + private static final int ACTIVITY_STARTUP_DELAY_MS = 1000; private ActivityMonitor mActivityMonitor; private ContextualSearchFakeServer mFakeServer;