Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

must_use on Gas::record_cost should point to gas! macro #1408

Closed
DaniPopes opened this issue May 13, 2024 · 0 comments · Fixed by #1413
Closed

must_use on Gas::record_cost should point to gas! macro #1408

DaniPopes opened this issue May 13, 2024 · 0 comments · Fixed by #1413
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@DaniPopes
Copy link
Collaborator

DaniPopes commented May 13, 2024 •
edited
Loading

The boolean return of Gas::record_cost must be used because otherwise out-of-gas is not returned correctly. The gas! macro should likely be used instead. This should be captured in the must_use attribute message.
@DaniPopes DaniPopes added documentation Improvements or additions to documentation good first issue Good for newcomers labels May 13, 2024
@DaniPopes DaniPopes mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: point to gas! in Gas::record_cost DaniPopes/revm
1 participant
@DaniPopes