-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Create2 From TxEnv #1182
Labels
Comments
It seems this has been handled; #[derive(Clone, Debug, PartialEq, Eq, Hash)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct TxEnv {
/// Caller aka Author aka transaction signer.
pub caller: Address,
/// The gas limit of the transaction.
pub gas_limit: u64,
/// The gas price of the transaction.
pub gas_price: U256,
/// The destination of the transaction.
pub transact_to: TransactTo,
/// The value sent to `transact_to`.
pub value: U256,
/// The data of the transaction.
pub data: Bytes,
/// The nonce of the transaction.
///
/// Caution: If set to `None`, then nonce validation against the account's nonce is skipped: [InvalidTransaction::NonceTooHigh] and [InvalidTransaction::NonceTooLow]
pub nonce: Option<u64>,
/// The chain ID of the transaction. If set to `None`, no checks are performed.
///
/// Incorporated as part of the Spurious Dragon upgrade via [EIP-155].
///
/// [EIP-155]: https://eips.ethereum.org/EIPS/eip-155
pub chain_id: Option<u64>,
/// A list of addresses and storage keys that the transaction plans to access.
///
/// Added in [EIP-2930].
///
/// [EIP-2930]: https://eips.ethereum.org/EIPS/eip-2930
pub access_list: Vec<(Address, Vec<U256>)>,
/// The priority fee per gas.
///
/// Incorporated as part of the London upgrade via [EIP-1559].
///
/// [EIP-1559]: https://eips.ethereum.org/EIPS/eip-1559
pub gas_priority_fee: Option<U256>,
/// The list of blob versioned hashes. Per EIP there should be at least
/// one blob present if [`Self::max_fee_per_blob_gas`] is `Some`.
///
/// Incorporated as part of the Cancun upgrade via [EIP-4844].
///
/// [EIP-4844]: https://eips.ethereum.org/EIPS/eip-4844
pub blob_hashes: Vec<B256>,
/// The max fee per blob gas.
///
/// Incorporated as part of the Cancun upgrade via [EIP-4844].
///
/// [EIP-4844]: https://eips.ethereum.org/EIPS/eip-4844
pub max_fee_per_blob_gas: Option<U256>,
#[cfg_attr(feature = "serde", serde(flatten))]
#[cfg(feature = "optimism")]
pub optimism: OptimismFields,
} |
Yes, it has been handled in #1143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add new enum that will remove Create2 from TxEnv.
Line here:
https://github.com/bluealloy/revm/blob/main/crates/primitives/src/env.rs#L496
CREATE2 is an opcode and not a tx version.
The text was updated successfully, but these errors were encountered: