Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mitigate possibility of scheduled builds disablement after 60 days of image repo inactivity #68

Open
fiftydinar opened this issue Nov 29, 2024 · 2 comments

Comments

@fiftydinar
Copy link
Collaborator

fiftydinar commented Nov 29, 2024

According to this keepalive-workflow, users can get this message if there is no activity to the repo for 60+ days:

105174930-4303e100-5b49-11eb-90ed-95a55697582f

Which means that their image wouldn't get any updates if they didn't commit anything for 60+ days.
This is not a good thing. Users should be able to just set & forget their image.

However, analyzing the Atomic Studio project, I can see that the last commit was done in 10th September at the time of writing, while the most-recent scheduled weekly build normally ran in 24th November, which is 75 days without any new commit.

So I'm not sure when this actually happens, on which scenarios & similar.

So we need to investigate if this needs to be solved at all:

  • if there's no need to solve this issue, we can conclude & close this issue
  • Otherwise, we should investigate the usage of keepalive-workflow in this action
@fiftydinar fiftydinar changed the title fix: Investigate possibility of scheduled builds disablement after 60 days of last repo commit fix: Mitigate possibility of scheduled builds disablement after 60 days of image repo inactivity Nov 29, 2024
@xynydev
Copy link
Member

xynydev commented Dec 1, 2024

This workflow creates a dummy commit every 60 days, which might litter a users commit history. I'm not really sure it's possible to integrate into the action either, so the path to implementing this might be changes in the template.

Anyways, I always get an email when one of my workflows is almost disabled, and I can choose to manually keep it enabled or not do anything and just let it turn off. I feel like this is a good enough solution to this from GitHub themselves, and that integrating a keepalive workflow for everyone by default would be overkill.

We may document this behaviour and workaround, though, if it's deemed an issue.

@gmpinder
Copy link
Member

gmpinder commented Dec 1, 2024

I agree, I think this might be better as a documented issue, and we can point to this GitHub action for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants