Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternate branch tag generation regression relative to startingpoint #99

Open
RoyalOughtness opened this issue Feb 27, 2024 · 8 comments
Labels
type: docs Related to documentation and information.

Comments

@RoyalOughtness
Copy link
Contributor

the tag generation based on other branch names is broken:

https://github.com/secureblue/secureblue/pkgs/container/silverblue-main-hardened/versions
staging is getting published as "cd9d6ba-39 br-staging-39"
instead of "39-staging" and "staging"

@xynydev
Copy link
Member

xynydev commented Feb 27, 2024

I think the br- prefix makes sense here, but with the other stuff I believe I discussed this with @gmpinder earlier. Maybe here, maybe some parts where somewhere else.

Anyway, I am of the opinion that there should at least be a br-staging tag that is the same as the latest tag but for the staging branch. The necessity of that prefix can be discussed.

@gmpinder
Copy link
Member

I'm fine with adding an exception for staging, but we should either leave it at that extra branch name being designated for testing or allow all branches to not have a br- prefix.

@RoyalOughtness
Copy link
Contributor Author

No need to add an exception just for us, we'll be fine without it. If the intention wasn't to preserve this functionality, then to close this ticket could be as simple as documentation for the new behavior

@gmpinder
Copy link
Member

We'll be sure to sign images so long as the public and private keys are accessible in the pipeline

@gmpinder
Copy link
Member

No need to add an exception just for us, we'll be fine without it. If the intention wasn't to preserve this functionality, then to close this ticket could be as simple as documentation for the new behavior

@xynydev where would this go?

@gmpinder gmpinder added the type: docs Related to documentation and information. label Feb 27, 2024
@xynydev
Copy link
Member

xynydev commented Feb 27, 2024

Not sure what you mean by that question. My earlier comment explains my stance on the topic.

@gmpinder
Copy link
Member

Not sure what you mean by that question. My earlier comment explains my stance on the topic.

Where would the documentation go?

@xynydev
Copy link
Member

xynydev commented Feb 28, 2024

Either a new page in the docs, but I think it'd belong to a reference page for the cli, which has yet to be made.

Such a page should document the public API of cli in great detail. The build --push tagging info would be a part of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Related to documentation and information.
Projects
None yet
Development

No branches or pull requests

3 participants