Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nvidia akmods logic needs to be updated #240

Closed
fiftydinar opened this issue Oct 12, 2024 · 1 comment · Fixed by #255
Closed

Nvidia akmods logic needs to be updated #240

fiftydinar opened this issue Oct 12, 2024 · 1 comment · Fixed by #255
Assignees
Labels
type: chore Converting measurements, reorganizing folder structure, and less impactful tasks.
Milestone

Comments

@fiftydinar
Copy link
Contributor

fiftydinar commented Oct 12, 2024

Ublue dropped versioning, so it always builds the newest one.
Which means that nvidia-version entry is no longer needed.

Maybe nvidia: false by default can substitute legacy nvidia-version entry.

They also build the image in proprietary & open kernel module, so they are versioned like this:
ghcr.io/ublue-os/akmods-nvidia:main-${OS_VERSION}
ghcr.io/ublue-os/akmods-nvidia-open:main-${OS_VERSION}

Maybe nvidia: open/proprietary entry option looks good.

What do you think?

@gmpinder gmpinder self-assigned this Oct 13, 2024
@gmpinder gmpinder added the type: chore Converting measurements, reorganizing folder structure, and less impactful tasks. label Oct 13, 2024
@gmpinder
Copy link
Member

I don't know if switching from a boolean to an enum would be a smart move. If I can find a way to accept both a bool and enum, that could work. We would have nvidia: true be equivalent to nvidia: proprietary since that logic would bear the same image. For nvidia-version, we can just ignore it/let the json schema handle validation.

@gmpinder gmpinder added this to the v0.9.0 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Converting measurements, reorganizing folder structure, and less impactful tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants