Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended documentation #12

Open
analyticalmonk opened this issue Nov 10, 2017 · 1 comment
Open

Extended documentation #12

analyticalmonk opened this issue Nov 10, 2017 · 1 comment

Comments

@analyticalmonk
Copy link

The documentation (README.md) doesn't give out a lot.
To figure out something even as simple as validating the secret token, I'd to go through the source code. That's not ideal.
I'll be using the framework in a couple of projects. I can help with the documentation and the repo admins can review it if that's acceptable.

@alex-ball
Copy link

It would have saved me a lot of debugging time if I had realised that you can't validate the signature from GitHub if the ping is sent as application/x-www-form-urlencoded (since request.data is then an empty binary string).

Some documentation of using the secret keyword argument would be greatly appreciated. Again, I'm happy to contribute this if the admins would like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants