Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partners Invite - Admin - Add New Users Invite Flow #1653

Closed
kathyccheng opened this issue Aug 11, 2021 · 10 comments
Closed

Partners Invite - Admin - Add New Users Invite Flow #1653

kathyccheng opened this issue Aug 11, 2021 · 10 comments
Assignees
Labels
blocked Further development is blocked waiting for something external to this ticket ready for qa Ready to be QA’d

Comments

@kathyccheng
Copy link
Collaborator

kathyccheng commented Aug 11, 2021

As an admin,
I want to be able to invite new users to the partners portal
So that I can add new leasing agents to their associated listing

Acceptance Criteria

  • When I am on the users page, then I will see a button to add user
  • When I click on the button to add user, then I will be take to the add user form which includes Name, Email, Role, and Listings
  • When I fill out the information and click Invite, then an email will be sent to the user and I will be taken back to the users page with a success message and the last user at the top of the list with the status Unconfirmed
  • When admin is selected, access to all listings is given, but don't show the listings section

User Flow
https://www.figma.com/file/aJZAf9SiDqj55uANa8CpzL/Access-Control-Flow?node-id=0%3A1

Designs
https://www.figma.com/file/Y8bFd0aSz7eYJ2TCNid6s3/bloom-partners?node-id=4084%3A169393

https://www.figma.com/file/Y8bFd0aSz7eYJ2TCNid6s3/bloom-partners?node-id=4084%3A169536

https://www.figma.com/file/Y8bFd0aSz7eYJ2TCNid6s3/bloom-partners?node-id=4084%3A169464

Email Copy

From: [email protected]
Subject Line: Welcome to the Partners Portal

Hello Name,

Welcome to the the Partners Portal on [URL]. You will now be able to manage listings and applications that you are a part of from one centralized location.

To complete your account creation, please click the link below:

Confirm my account

Thank you,
Alameda County - Housing and Community Development (HCD) Department

--
Modeled after our current user account welcome email
image

@kathyccheng kathyccheng changed the title Add New Users Invite Flow Admin - Add New Users Invite Flow Aug 11, 2021
@slowbot
Copy link
Collaborator

slowbot commented Aug 11, 2021

@kathyccheng Adding user flow to this issue

@kathyccheng
Copy link
Collaborator Author

@slowbot I drafted some email language above, let me know what you think

@slowbot
Copy link
Collaborator

slowbot commented Aug 16, 2021

@kathyccheng Looks pretty good to me. I would have started with our existing user email too.

@kathyccheng kathyccheng added the blocked Further development is blocked waiting for something external to this ticket label Aug 23, 2021
@kathyccheng kathyccheng changed the title Admin - Add New Users Invite Flow Partners Invite - Admin - Add New Users Invite Flow Aug 25, 2021
@pbn4
Copy link
Contributor

pbn4 commented Aug 26, 2021

@seanmalbert I think we should go with creating a separate admin only action called invite (added to authz_policy.csv) for User model in which we both create a user, set roles and assign listings. Reusing existing create action for this would require us to distinguish roles (e.g. disallow normal user from modifying UserRoles) and we should also exclusively pick which kind of email to send. That seems like adding unnecesary conditional logic to an endpoint which is already doing quite big amount of stuff. What do you think?

In the past I was reluctant to creating actions/verbs in REST API URI's but I think what we would like to create here actually leads to an easier to use API, please read this thread for some reasoning: https://stackoverflow.com/a/56126573

@seanmalbert
Copy link
Collaborator

@pbn4 , I like this idea. In the past, I was reluctant too and have definitely gone down the road of trying to have a slim yet robust set of endpoints and it always ends up being a challenge to maintain.

This endpoint should be able to handle not only assigning the user roles but also assigning listings, right?

@pbn4 pbn4 self-assigned this Aug 26, 2021
@pbn4
Copy link
Contributor

pbn4 commented Aug 30, 2021

This endpoint should be able to handle not only assigning the user roles but also assigning listings, right?

@seanmalbert Yes thats what I had in mind.

@seanmalbert
Copy link
Collaborator

@dominikx96 , after you address the issues noted in #1651 , you can start on this. If #1801 hasn't been merged by then, please work off of that branch and with @pbn4 to get started on the front piece of this.

@kathyccheng kathyccheng removed the blocked Further development is blocked waiting for something external to this ticket label Sep 16, 2021
@kathyccheng kathyccheng assigned dominikx96 and unassigned pbn4 Sep 16, 2021
@dominikx96 dominikx96 added ready for qa Ready to be QA’d and removed in-development labels Sep 30, 2021
@slowbot slowbot added the blocked Further development is blocked waiting for something external to this ticket label Oct 13, 2021
@slowbot
Copy link
Collaborator

slowbot commented Oct 13, 2021

Blocked from QA by #1980

@kathyccheng
Copy link
Collaborator Author

I think this flow is good

@slowbot
Copy link
Collaborator

slowbot commented Oct 14, 2021

Email has a bug @kathyccheng

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Further development is blocked waiting for something external to this ticket ready for qa Ready to be QA’d
Projects
None yet
Development

No branches or pull requests

5 participants