From 75c0ce8b53c95f9e2e5519ee2442e09c0c28f71b Mon Sep 17 00:00:00 2001 From: blockchaindevsh Date: Mon, 4 Nov 2024 20:53:39 +0800 Subject: [PATCH 1/2] fix just build warning --- packages/contracts-bedrock/src/L2/L1Block.sol | 2 +- packages/contracts-bedrock/src/L2/interfaces/IL1Block.sol | 2 +- .../contracts-bedrock/src/L2/interfaces/IL1BlockInterop.sol | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/contracts-bedrock/src/L2/L1Block.sol b/packages/contracts-bedrock/src/L2/L1Block.sol index 23b4492c06dc..3b6b020ddd57 100644 --- a/packages/contracts-bedrock/src/L2/L1Block.sol +++ b/packages/contracts-bedrock/src/L2/L1Block.sol @@ -209,7 +209,7 @@ contract L1Block is ISemver, IGasToken { } /// @notice Returns the size of history hashes. - function historySize() external view returns (uint256) { + function historySize() external pure returns (uint256) { return HISTORY_SIZE; } } diff --git a/packages/contracts-bedrock/src/L2/interfaces/IL1Block.sol b/packages/contracts-bedrock/src/L2/interfaces/IL1Block.sol index 0ae477facd6c..1e7cb415002f 100644 --- a/packages/contracts-bedrock/src/L2/interfaces/IL1Block.sol +++ b/packages/contracts-bedrock/src/L2/interfaces/IL1Block.sol @@ -39,6 +39,6 @@ interface IL1Block { function __constructor__() external; - function historySize() external view returns (uint256); + function historySize() external pure returns (uint256); function blockHash(uint256 _historyNumber) external view returns (bytes32); } diff --git a/packages/contracts-bedrock/src/L2/interfaces/IL1BlockInterop.sol b/packages/contracts-bedrock/src/L2/interfaces/IL1BlockInterop.sol index a10c82e7ae49..b9fa78733e78 100644 --- a/packages/contracts-bedrock/src/L2/interfaces/IL1BlockInterop.sol +++ b/packages/contracts-bedrock/src/L2/interfaces/IL1BlockInterop.sol @@ -58,6 +58,6 @@ interface IL1BlockInterop { function __constructor__() external; - function historySize() external view returns (uint256); + function historySize() external pure returns (uint256); function blockHash(uint256 _historyNumber) external view returns (bytes32); } From 22af1e181c73f1413a83c8a8910ee56123697ff0 Mon Sep 17 00:00:00 2001 From: blockchaindevsh Date: Mon, 4 Nov 2024 22:31:33 +0800 Subject: [PATCH 2/2] fix just build error --- packages/contracts-bedrock/scripts/checks/interfaces/main.go | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/contracts-bedrock/scripts/checks/interfaces/main.go b/packages/contracts-bedrock/scripts/checks/interfaces/main.go index 73d3af062707..6a141f7ccde5 100644 --- a/packages/contracts-bedrock/scripts/checks/interfaces/main.go +++ b/packages/contracts-bedrock/scripts/checks/interfaces/main.go @@ -29,6 +29,7 @@ var excludeContracts = []string{ "IInitializable", "ILegacyMintableERC20", "IOptimismMintableERC20", "IOptimismMintableERC721", "KontrolCheatsBase", "IWETH", "IDelayedWETH", "ISuperchainWETH", "IL2ToL2CrossDomainMessenger", "ICrossL2Inbox", "ISystemConfigInterop", "IResolvedDelegateProxy", + "IERC20Upgradeable", } type ContractDefinition struct {