Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move schema->proto generation to use static analysis #2935

Closed
alecthomas opened this issue Oct 1, 2024 · 0 comments · Fixed by #2973
Closed

Move schema->proto generation to use static analysis #2935

alecthomas opened this issue Oct 1, 2024 · 0 comments · Fixed by #2973
Assignees
@alecthomas
Labels
techdebt Issue is technical debt

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Oct 1, 2024 •
edited
Loading

It currently uses reflection, which causes a chicken-and-egg situation when adding new types to the schema whereby the reflection code can't be run because the types aren't complete.

Stretch goal: generate ToProto() methods and XxxFromProto() functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alecthomas alecthomas

Labels
techdebt Issue is technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: statically extract .proto from Go source block/ftl
1 participant
@alecthomas