Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeline records for ingress requests that failed before being called #2518

Closed
matt2e opened this issue Aug 28, 2024 · 4 comments · Fixed by #2735
Closed

Add timeline records for ingress requests that failed before being called #2518

matt2e opened this issue Aug 28, 2024 · 4 comments · Fixed by #2735
Labels
console Web console dx next Work that will be be picked up next

Comments

@matt2e
Copy link
Collaborator

matt2e commented Aug 28, 2024

Use case we are seeing from our partner project:

  • A bad call came into the API
  • They want to see the content of the request to find out what went wrong
  • They can not find out because we did not save a timeline record for the call

Code details:

@github-actions github-actions bot added the triage Issue needs triaging label Aug 28, 2024
@ftl-robot ftl-robot mentioned this issue Aug 28, 2024
@alecthomas
Copy link
Collaborator

We can't record it as a "call" event because that event needs the response, but we should create an "ingress" event and record that.

@matt2e
Copy link
Collaborator Author

matt2e commented Aug 28, 2024

Could these be logged as calls with response = nil, callError = ...? That would match other call failures

@alecthomas
Copy link
Collaborator

I think it would make more sense to be a separate event, regardless. An ingress request is inherently separate to the Verb call that services it.

@wesbillman
Copy link
Collaborator

wesbillman commented Aug 28, 2024

#2521

We currently only record calls but it's possible to fail at ingress before hitting the calls event code.

This will require updates to the console as well to visualize the ingress events.

@bradleydwyer bradleydwyer added next Work that will be be picked up next and removed triage Issue needs triaging labels Aug 28, 2024
@wesbillman wesbillman added console Web console dx labels Aug 28, 2024
@wesbillman wesbillman changed the title Add timeline records for calls that failed before being attempted Add timeline records for ingress requests that failed before being called Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Web console dx next Work that will be be picked up next
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants