Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java verb calls don't have a way to stop when cancelled #2509

Closed
matt2e opened this issue Aug 27, 2024 · 2 comments
Closed

Java verb calls don't have a way to stop when cancelled #2509

matt2e opened this issue Aug 27, 2024 · 2 comments
Labels

Comments

@matt2e
Copy link
Collaborator

matt2e commented Aug 27, 2024

Java does not currently have a way to stop execution of the call that gets canceled, so it will always continue even when the async call's lease expires.

Go does this by cancelling the context when the call grpc request ends, so when a verb tries to use the context things should fail.

Speaking with @stuartwdouglas last week, it sounds non-obvious as to the best way to do this in Java.

@matt2e matt2e added the jvm label Aug 27, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Aug 27, 2024
@ftl-robot ftl-robot mentioned this issue Aug 27, 2024
@matt2e
Copy link
Collaborator Author

matt2e commented Aug 27, 2024

@gak
Copy link
Contributor

gak commented Aug 27, 2024

Tricky in Java. Will revisit if needed.

@gak gak closed this as completed Aug 27, 2024
@gak gak removed the triage Issue needs triaging label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants