Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need for a released lease to log at warning level #2160

Closed
matt2e opened this issue Jul 24, 2024 · 1 comment
Closed

No need for a released lease to log at warning level #2160

matt2e opened this issue Jul 24, 2024 · 1 comment
Assignees
@matt2e

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jul 24, 2024 •
edited
Loading

Lease heartbeat terminated: canceled: context canceled
It seems that when logs are obtained by module code and the released we log a warning that the lease heartbeat has been terminated due to a canceled context.

... or there may be a legit issue being exposed here. Need to research more.
@matt2e matt2e self-assigned this Jul 24, 2024
@matt2e matt2e changed the title No need for leases to log the happy case: Lease heartbeat terminated: canceled: context canceled No need for a released lease to log at warning level Jul 24, 2024
@ftl-robot ftl-robot mentioned this issue Jul 24, 2024
Open
@matt2e matt2e mentioned this issue Jul 25, 2024
Closed
@matt2e
Copy link
Collaborator Author

matt2e commented Jul 26, 2024

Fixed

@matt2e matt2e closed this as completed Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve lease log level and include key block/ftl
1 participant
@matt2e